cloud-fan commented on a change in pull request #23651: [SPARK-26730][SQL]
Strip redundant AssertNotNull for ExpressionEncoder's serializer
URL: https://github.com/apache/spark/pull/23651#discussion_r251312976
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoder.scala
##########
@@ -192,6 +192,9 @@ case class ExpressionEncoder[T](
if (isSerializedAsStructForTopLevel) {
val nullSafeSerializer = objSerializer.transformUp {
+ case _ @ AssertNotNull(a: AssertNotNull, _) =>
+ // strip redundant AssertNotNull
+ a
case r: BoundReference =>
Review comment:
I think we should strip `AssertNotNull` there:
```
val fieldValue = Invoke(
inputObject, fieldName, dataTypeFor(fieldType),
returnNullable = !fieldType.typeSymbol.asClass.isPrimitive)
```
The `fieldValue` is used in `nonNullOutput` in
```
expressions.If(IsNull(inputObject), nullOutput, nonNullOutput)
```
So `inputObject` can't be null already
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
