gaborgsomogyi commented on a change in pull request #23156: [SPARK-24063][SS]
Add maximum epoch queue threshold for ContinuousExecution
URL: https://github.com/apache/spark/pull/23156#discussion_r251441909
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/continuous/ContinuousExecution.scala
##########
@@ -277,6 +281,10 @@ class ContinuousExecution(
lastExecution.toRdd
}
}
+
+ failureLock.synchronized {
Review comment:
It is syncronized for 2 reasons:
1. `lastExecution.toRdd` stands in one thread and `stopInNewThread` stops
processing in a new thread. The reason of this construct is not to have
deadlock.
2. Exception thrown by`epochUpdateThread` is not handled at the moment. If
an exception comes it's abandoned and processing doesn't stop. I will file a
new jira to handle this (another thread will make modifications on the
`failure` variable).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
