jose-torres commented on a change in pull request #23619: [SPARK-26695][SQL]
data source v2 API refactor - continuous read
URL: https://github.com/apache/spark/pull/23619#discussion_r251517284
##########
File path:
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaContinuousSourceSuite.scala
##########
@@ -209,11 +209,11 @@ class KafkaContinuousSourceTopicDeletionSuite extends
KafkaContinuousTest {
assert(
query.lastExecution.executedPlan.collectFirst {
case scan: ContinuousScanExec
- if scan.readSupport.isInstanceOf[KafkaContinuousReadSupport] =>
- scan.scanConfig.asInstanceOf[KafkaContinuousScanConfig]
- }.exists { config =>
+ if scan.stream.isInstanceOf[KafkaContinuousStream] =>
Review comment:
I think this logic is correct, but let's keep an eye on the tests after
merging since some flakiness slipped through in the last iteration of the
refactoring.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]