HeartSaVioR commented on issue #23612: [SPARK-26686][SS] Remove unnecessary KafkaSourceProvider parameter lowercase conversion URL: https://github.com/apache/spark/pull/23612#issuecomment-458272203 To be short, what I concerned is guaranteeing case-insensitive is not same as guaranteeing lower keys (I'm not also 100% feeling safe on 'normalized' since it can be also done with upper keys). I've seen javadoc in some interfaces guaranteed former, but not latter. IMHO to remove the conversion (which the patch is trying to achieve), the interfaces need to guarantee latter, or Kafka should be able to handle the parameters by case-insensitive manner.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
