linehrr commented on a change in pull request #23666: [SPARK-26718][SS] Fixed
integer overflow in SS kafka rateLimit calculation
URL: https://github.com/apache/spark/pull/23666#discussion_r251583959
##########
File path:
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaMicroBatchSourceSuite.scala
##########
@@ -204,6 +204,43 @@ abstract class KafkaMicroBatchSourceSuiteBase extends
KafkaSourceSuiteBase {
StopStream)
}
+ test("Rate limit set to Long.Max should not overflow integer " +
+ "during end offset calculation[SPARK-26718]") {
Review comment:
ok I got the idea that ticket number should be at the end from test case: `
test("ensure that initial offset are written with an extra byte in the
beginning (SPARK-19517)") {`, but I can put it at the front.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
