dongjoon-hyun commented on a change in pull request #23606: [SPARK-26666][SQL]
Support DSv2 overwrite and dynamic partition overwrite.
URL: https://github.com/apache/spark/pull/23606#discussion_r251616435
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala
##########
@@ -144,14 +146,22 @@ object DataSourceV2Strategy extends Strategy {
WriteToDataSourceV2Exec(writer, planLater(query)) :: Nil
case AppendData(r: DataSourceV2Relation, query, _) =>
- val writeBuilder = r.newWriteBuilder(query.schema)
- writeBuilder match {
- case s: SupportsSaveMode =>
- val write = s.mode(SaveMode.Append).buildForBatch()
- assert(write != null)
- WriteToDataSourceV2Exec(write, planLater(query)) :: Nil
- case _ => throw new AnalysisException(s"data source ${r.name} does not
support SaveMode")
- }
+ AppendDataExec(
+ r.table.asBatchWritable, r.options.toDataSourceOptions,
planLater(query)) :: Nil
+
+ case OverwriteByExpression(r: DataSourceV2Relation, deleteExpr, query, _)
=>
+ // fail if any filter cannot be converted. correctness depends on
removing all matching data.
+ val filters = splitConjunctivePredicates(deleteExpr).map {
+ filter => DataSourceStrategy.translateFilter(deleteExpr).getOrElse(
+ throw new SparkException(s"Cannot translate expression to source
filter: $filter"))
Review comment:
@rdblue .
I know the logic, but we already use `AnalysisException` in this file. It's
based on the characteristic of the exception instead of the location. Please
see what you removed. For me, `SparkException` is just too broad.
-
https://github.com/apache/spark/pull/23606/files#diff-fc4a83061d40a242e7f7b729cb8ee870L153
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
