viirya commented on a change in pull request #23628: [SPARK-26702][SQL][TEST]
Create a test trait for Parquet and Orc test
URL: https://github.com/apache/spark/pull/23628#discussion_r251672020
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcTest.scala
##########
@@ -66,46 +71,30 @@ abstract class OrcTest extends QueryTest with SQLTestUtils
with BeforeAndAfterAl
*/
protected def withOrcFile[T <: Product: ClassTag: TypeTag]
Review comment:
If you suggest to replace the usage of withOrcFile with new method, seems to
me we can keep them because they are used many places. To replace them all,
there will be a tedious diff. Maybe it is not worth now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
