squito commented on issue #23438: [SPARK-26525][SHUFFLE]Fast release 
ShuffleBlockFetcherIterator on completion of the iteration
URL: https://github.com/apache/spark/pull/23438#issuecomment-458384306
 
 
   I just had another idea -- maybe instead you create a separate class for the 
TaskCompletionListener (instead of having it be an anonymous inner class in 
ShuffleBlockFetcherIterator), and when the end of the iterator is reached, you 
could null out the reference to the ShuffleBlockFetcherIterator.  The 
TaskCompletionListener woudl still get called later at the end of the task, but 
it wouldn't be holding onto the ShuffleBlockFetcherIterator, and its action 
would be a no-op.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to