cloud-fan commented on issue #23438: [SPARK-26525][SHUFFLE]Fast release 
ShuffleBlockFetcherIterator on completion of the iteration
URL: https://github.com/apache/spark/pull/23438#issuecomment-458393253
 
 
   > IMO, its not unreasonable to add this api.
   
   Yea I agree with it, but up to my experience, this kind of problem has a 
simpler fix: just null out/clear the real data, instead of avoiding the 
reference of the outer object.
   
   I haven't looked into the code it, but `ShuffleBlockFetcherIterator` has 
many maps/sets, maybe we just need to clear them in `cleanup`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to