dongjoon-hyun commented on a change in pull request #23628: [SPARK-26702][SQL][TEST] Create a test trait for Parquet and Orc test URL: https://github.com/apache/spark/pull/23628#discussion_r251704005
########## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcTest.scala ########## @@ -42,13 +43,17 @@ import org.apache.spark.sql.test.SQLTestUtils * -> OrcFilterSuite * -> HiveOrcFilterSuite */ -abstract class OrcTest extends QueryTest with SQLTestUtils with BeforeAndAfterAll { +abstract class OrcTest extends QueryTest with FileBasedDataSourceTest with BeforeAndAfterAll { import testImplicits._ Review comment: Also, let's remove this `testImplicits`. ```scala - import testImplicits._ ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org