gaborgsomogyi edited a comment on issue #23612: [SPARK-26686][SS] Remove unnecessary KafkaSourceProvider parameter lowercase conversion URL: https://github.com/apache/spark/pull/23612#issuecomment-458473434 What I would like to do here is order because there are some code lines which do validation without making things lowecase for example [this](https://github.com/apache/spark/blob/e97ab1d9807134bb557ae73920af61e8534b2b08/external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala#L66), [this](https://github.com/apache/spark/blob/e97ab1d9807134bb557ae73920af61e8534b2b08/external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala#L81) and [this](https://github.com/apache/spark/blob/e97ab1d9807134bb557ae73920af61e8534b2b08/external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala#L118). I'm fine with moving the mentioned codeparts after the lowercase conversion but what I'm sure we need to do something because part of the parameter handling is depending on the (maybe wrong) fact that it's already lowered. Opinions?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
