mgaido91 commented on a change in pull request #23267: [SPARK-25401] [SQL]
Reorder join predicates to match child outputOrdering
URL: https://github.com/apache/spark/pull/23267#discussion_r251785037
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/EnsureRequirements.scala
##########
@@ -293,6 +314,21 @@ case class EnsureRequirements(conf: SQLConf) extends
Rule[SparkPlan] {
}
}
+ private def reorderJoinPredicatesForOrdering(plan: SparkPlan): SparkPlan = {
Review comment:
I think we can avoid this and include this transformation in the former
`reorderJoinPredicates` method, after the reorder for partitionings. I'd rather
have a `reorderJoinKeysForOrderings` called there or something similar.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
