maropu commented on a change in pull request #20303: [SPARK-23128][SQL] A new
approach to do adaptive execution in Spark SQL
URL: https://github.com/apache/spark/pull/20303#discussion_r251801334
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -282,14 +282,19 @@ object SQLConf {
val SHUFFLE_MIN_NUM_POSTSHUFFLE_PARTITIONS =
buildConf("spark.sql.adaptive.minNumPostShufflePartitions")
- .internal()
- .doc("The advisory minimal number of post-shuffle partitions provided to
" +
- "ExchangeCoordinator. This setting is used in our test to make sure we
" +
- "have enough parallelism to expose issues that will not be exposed
with a " +
- "single partition. When the value is a non-positive value, this
setting will " +
- "not be provided to ExchangeCoordinator.")
+ .doc("The advisory minimum number of post-shuffle partitions used in
adaptive execution.")
+ .intConf
+ .checkValue(numPartitions => numPartitions > 0, "The minimum shuffle
partition number " +
+ "must be a positive integer.")
+ .createWithDefault(1)
+
+ val SHUFFLE_MAX_NUM_POSTSHUFFLE_PARTITIONS =
+ buildConf("spark.sql.adaptive.maxNumPostShufflePartitions")
+ .doc("The advisory maximum number of post-shuffle partitions used in
adaptive execution.")
.intConf
- .createWithDefault(-1)
+ .checkValue(numPartitions => numPartitions > 0, "The maximum shuffle
partition number " +
+ "must be a positive integer.")
+ .createWithDefault(500)
Review comment:
We don't support a negative case in a new execution model, `When the value
is a non-positive value, this setting will not be provided to
ExchangeCoordinator`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
