maropu commented on a change in pull request #23267: [SPARK-25401] [SQL]
Reorder join predicates to match child outputOrdering
URL: https://github.com/apache/spark/pull/23267#discussion_r251826192
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/EnsureRequirements.scala
##########
@@ -276,7 +297,7 @@ case class EnsureRequirements(conf: SQLConf) extends
Rule[SparkPlan] {
* introduced). This rule will change the ordering of the join keys to match
with the
* partitioning of the join nodes' children.
*/
- private def reorderJoinPredicates(plan: SparkPlan): SparkPlan = {
Review comment:
In the historical reason
(https://github.com/apache/spark/pull/19257#issuecomment-345278009), this
method was added as a workaround. So, I feel it is compliated to extend this
method for this case... basically, IMO we need a general logic here to conver
this case and more. cc: @cloud-fan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
