srowen commented on a change in pull request #23685:
[SPARK-26771][CORE][GRAPHX] Make .unpersist(), .destroy() consistently
non-blocking by default
URL: https://github.com/apache/spark/pull/23685#discussion_r251863830
##########
File path: core/src/main/scala/org/apache/spark/SparkContext.scala
##########
@@ -1753,7 +1753,7 @@ class SparkContext(config: SparkConf) extends Logging {
/**
* Unpersist an RDD from memory and/or disk storage
*/
- private[spark] def unpersistRDD(rddId: Int, blocking: Boolean = true) {
+ private[spark] def unpersistRDD(rddId: Int, blocking: Boolean) {
Review comment:
This is a private method and its optional arg value is always specified, so,
I removed the default to avoid confusion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
