srowen commented on a change in pull request #23602: [SPARK-26674][CORE]Consolidate CompositeByteBuf when reading large frame URL: https://github.com/apache/spark/pull/23602#discussion_r251870396
########## File path: common/network-common/src/test/java/org/apache/spark/network/util/TransportFrameDecoderSuite.java ########## @@ -22,6 +22,7 @@ import java.util.Random; import java.util.concurrent.atomic.AtomicInteger; +import com.google.common.collect.Lists; Review comment: Nit: I wouldn't import this library just to make an ArrayList. In Java 8, just: `List<ByteBuf> retained = new ArrayList<>();` which is no more complex. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
