maropu commented on issue #23654: [SPARK-26732][CORE][TEST] Wait for listener bus to process events in SparkContextInfoSuite. URL: https://github.com/apache/spark/pull/23654#issuecomment-458766855 This pr looks ok. btw, I was just wondering; we need to set a timeout value case-by-case? (nitpicking though...) ``` maropu@~/Repositories/spark/spark-master/core/src/test/scala/org/apache/spark: (master $>)$grep -nr "waitUntilEmpty" . ./AccumulatorSuite.scala:129: sc.listenerBus.waitUntilEmpty(10 * 1000) ./deploy/LogUrlsStandaloneSuite.scala:44: sc.listenerBus.waitUntilEmpty(WAIT_TIMEOUT_MILLIS) ./deploy/LogUrlsStandaloneSuite.scala:64: sc.listenerBus.waitUntilEmpty(WAIT_TIMEOUT_MILLIS) ./ExecutorAllocationManagerSuite.scala:59: bus.waitUntilEmpty(1000) ./metrics/InputOutputMetricsSuite.scala:185: sc.listenerBus.waitUntilEmpty(500) ./metrics/InputOutputMetricsSuite.scala:246: sc.listenerBus.waitUntilEmpty(500) ./metrics/InputOutputMetricsSuite.scala:256: sc.listenerBus.waitUntilEmpty(500) ./metrics/InputOutputMetricsSuite.scala:296: sc.listenerBus.waitUntilEmpty(500) ./scheduler/DAGSchedulerSuite.scala:368: sc.listenerBus.waitUntilEmpty(WAIT_TIMEOUT_MILLIS) ./scheduler/DAGSchedulerSuite.scala:611: sc.listenerBus.waitUntilEmpty(WAIT_TIMEOUT_MILLIS) ./scheduler/DAGSchedulerSuite.scala:621: sc.listenerBus.waitUntilEmpty(WAIT_TIMEOUT_MILLIS) ./scheduler/DAGSchedulerSuite.scala:632: sc.listenerBus.waitUntilEmpty(WAIT_TIMEOUT_MILLIS) ./scheduler/DAGSchedulerSuite.scala:689: sc.listenerBus.waitUntilEmpty(WAIT_TIMEOUT_MILLIS) ./scheduler/DAGSchedulerSuite.scala:892: sc.listenerBus.waitUntilEmpty(1000) ./scheduler/DAGSchedulerSuite.scala:929: sc.listenerBus.waitUntilEmpty(1000) ./scheduler/DAGSchedulerSuite.scala:1051: sc.listenerBus.waitUntilEmpty(1000) ./scheduler/DAGSchedulerSuite.scala:1074: sc.listenerBus.waitUntilEmpty(WAIT_TIMEOUT_MILLIS) ./scheduler/DAGSchedulerSuite.scala:1083: sc.listenerBus.waitUntilEmpty(WAIT_TIMEOUT_MILLIS) ./scheduler/DAGSchedulerSuite.scala:1112: sc.listenerBus.waitUntilEmpty(WAIT_TIMEOUT_MILLIS) ./scheduler/DAGSchedulerSuite.scala:1141: sc.listenerBus.waitUntilEmpty(WAIT_TIMEOUT_MILLIS) ./scheduler/DAGSchedulerSuite.scala:1167: sc.listenerBus.waitUntilEmpty(WAIT_TIMEOUT_MILLIS) ./scheduler/DAGSchedulerSuite.scala:1189: sc.listenerBus.waitUntilEmpty(WAIT_TIMEOUT_MILLIS) ./scheduler/DAGSchedulerSuite.scala:1206: sc.listenerBus.waitUntilEmpty(WAIT_TIMEOUT_MILLIS) ./scheduler/DAGSchedulerSuite.scala:1211: sc.listenerBus.waitUntilEmpty(WAIT_TIMEOUT_MILLIS) ./scheduler/DAGSchedulerSuite.scala:1228: sc.listenerBus.waitUntilEmpty(WAIT_TIMEOUT_MILLIS) ./scheduler/DAGSchedulerSuite.scala:1253: sc.listenerBus.waitUntilEmpty(WAIT_TIMEOUT_MILLIS) ./scheduler/DAGSchedulerSuite.scala:1262: sc.listenerBus.waitUntilEmpty(WAIT_TIMEOUT_MILLIS) ./scheduler/DAGSchedulerSuite.scala:1277: sc.listenerBus.waitUntilEmpty(WAIT_TIMEOUT_MILLIS) ./scheduler/DAGSchedulerSuite.scala:1307: sc.listenerBus.waitUntilEmpty(WAIT_TIMEOUT_MILLIS) ./scheduler/DAGSchedulerSuite.scala:1319: sc.listenerBus.waitUntilEmpty(WAIT_TIMEOUT_MILLIS) ./scheduler/DAGSchedulerSuite.scala:1330: sc.listenerBus.waitUntilEmpty(WAIT_TIMEOUT_MILLIS) ./scheduler/DAGSchedulerSuite.scala:1337: sc.listenerBus.waitUntilEmpty(WAIT_TIMEOUT_MILLIS) ./scheduler/DAGSchedulerSuite.scala:1411: sc.listenerBus.waitUntilEmpty(WAIT_TIMEOUT_MILLIS) ./scheduler/DAGSchedulerSuite.scala:1655: sc.listenerBus.waitUntilEmpty(WAIT_TIMEOUT_MILLIS) ./scheduler/DAGSchedulerSuite.scala:2618: sc.listenerBus.waitUntilEmpty(1000) ./scheduler/DAGSchedulerSuite.scala:2636: sc.listenerBus.waitUntilEmpty(WAIT_TIMEOUT_MILLIS) ./scheduler/DAGSchedulerSuite.scala:2654: sc.listenerBus.waitUntilEmpty(WAIT_TIMEOUT_MILLIS) ./scheduler/DAGSchedulerSuite.scala:2673: sc.listenerBus.waitUntilEmpty(WAIT_TIMEOUT_MILLIS) ./scheduler/DAGSchedulerSuite.scala:2685: sc.listenerBus.waitUntilEmpty(WAIT_TIMEOUT_MILLIS) ./scheduler/DAGSchedulerSuite.scala:2698: sc.listenerBus.waitUntilEmpty(WAIT_TIMEOUT_MILLIS) ./scheduler/SparkListenerSuite.scala:68: sc.listenerBus.waitUntilEmpty(WAIT_TIMEOUT_MILLIS) ./scheduler/SparkListenerSuite.scala:100: bus.waitUntilEmpty(WAIT_TIMEOUT_MILLIS) ./scheduler/SparkListenerSuite.scala:226: sc.listenerBus.waitUntilEmpty(WAIT_TIMEOUT_MILLIS) ./scheduler/SparkListenerSuite.scala:251: sc.listenerBus.waitUntilEmpty(WAIT_TIMEOUT_MILLIS) ./scheduler/SparkListenerSuite.scala:260: sc.listenerBus.waitUntilEmpty(WAIT_TIMEOUT_MILLIS) ./scheduler/SparkListenerSuite.scala:269: sc.listenerBus.waitUntilEmpty(WAIT_TIMEOUT_MILLIS) ./scheduler/SparkListenerSuite.scala:285: sc.listenerBus.waitUntilEmpty(WAIT_TIMEOUT_MILLIS) ./scheduler/SparkListenerSuite.scala:313: sc.listenerBus.waitUntilEmpty(WAIT_TIMEOUT_MILLIS) ./scheduler/SparkListenerSuite.scala:324: sc.listenerBus.waitUntilEmpty(WAIT_TIMEOUT_MILLIS) ./scheduler/SparkListenerSuite.scala:375: sc.listenerBus.waitUntilEmpty(WAIT_TIMEOUT_MILLIS) ./scheduler/SparkListenerSuite.scala:391: sc.listenerBus.waitUntilEmpty(WAIT_TIMEOUT_MILLIS) ./scheduler/SparkListenerSuite.scala:446: bus.waitUntilEmpty(WAIT_TIMEOUT_MILLIS) ./scheduler/SparkListenerSuite.scala:516: bus.waitUntilEmpty(WAIT_TIMEOUT_MILLIS) ./scheduler/SparkListenerSuite.scala:525: bus.waitUntilEmpty(WAIT_TIMEOUT_MILLIS) ./scheduler/SparkListenerWithClusterSuite.scala:53: sc.listenerBus.waitUntilEmpty(WAIT_TIMEOUT_MILLIS) ./scheduler/TaskSchedulerImplSuite.scala:843: sc.listenerBus.waitUntilEmpty(100000) ./ShuffleSuite.scala:495: sc.listenerBus.waitUntilEmpty(500) ./SparkContextSuite.scala:703: sc.listenerBus.waitUntilEmpty(10000) ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
