jerryshao commented on a change in pull request #23560: [SPARK-26632][Spark
Core] Separate Thread Configurations of Driver and Executor
URL: https://github.com/apache/spark/pull/23560#discussion_r252093528
##########
File path:
core/src/main/scala/org/apache/spark/network/netty/SparkTransportConf.scala
##########
@@ -55,4 +69,27 @@ object SparkTransportConf {
}
})
}
+
+ /**
+ * Separate threads configuration of driver and executor
+ * @param conf the [[SparkConf]]
+ * @param module the module name
+ * @param server if true, it's for the serverThreads. Otherwise, it's for
the clientThreads.
+ * @return the configured number of threads, or -1 if not configured.
+ */
+ def getSpecificNumOfThreads(
+ conf: SparkConf,
+ module: String,
+ server: Boolean): Int = {
Review comment:
Using `boolean` to differentiate driver and executor seems not so straight
forward, also if we want to extend this method to other scenarios not just
"driver" and "executor", this method seems cannot satisfy, so can we make this
method more clear by passing "role" through parameters?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
