liupc commented on a change in pull request #23438: [SPARK-26525][SHUFFLE]Fast release ShuffleBlockFetcherIterator on completion of the iteration URL: https://github.com/apache/spark/pull/23438#discussion_r252124818
########## File path: core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala ########## @@ -609,6 +617,27 @@ private class BufferReleasingInputStream( override def reset(): Unit = delegate.reset() } +/** + * A listener to be called at the completion of the ShuffleBlockFetcherIterator + * @param data the ShuffleBlockFetcherIterator to process + */ +private class ShuffleFetchCompletionListener(var data: ShuffleBlockFetcherIterator) Review comment: @advancedxy it's ok, I have no idea which is better, so I just put it here. Seems not common to make similar class as an inner class in spark? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
