maropu commented on a change in pull request #23685:
[SPARK-26771][CORE][GRAPHX] Make .unpersist(), .destroy() consistently
non-blocking by default
URL: https://github.com/apache/spark/pull/23685#discussion_r252093573
##########
File path: core/src/main/scala/org/apache/spark/rdd/RDD.scala
##########
@@ -212,11 +212,11 @@ abstract class RDD[T: ClassTag](
/**
* Mark the RDD as non-persistent, and remove all blocks for it from memory
and disk.
*
- * @param blocking Whether to block until all blocks are deleted.
+ * @param blocking Whether to block until all blocks are deleted; default is
false
* @return This RDD.
*/
- def unpersist(blocking: Boolean = true): this.type = {
- logInfo("Removing RDD " + id + " from persistence list")
+ def unpersist(blocking: Boolean = false): this.type = {
+ logInfo(s"Removing RDD $id from persistence list")
Review comment:
How about documenting this behaviour in the RDD programming guide? e.g.,
non-blocking by default. If you block it until unpersist finishes, you need to
set `blocking = true`, brabrabra...
https://spark.apache.org/docs/latest/rdd-programming-guide.html#removing-data
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
