gaborgsomogyi commented on issue #23686: [SPARK-26772][YARN] YARNHadoopDelegationTokenManager loads ServiceCredentialProviders independently URL: https://github.com/apache/spark/pull/23686#issuecomment-458880615 Presume @vanzin meant make `HadoopDelegationTokenProvider` a `@DeveloperApi`. In general I support this idea, only one question. [Here](https://issues.apache.org/jira/browse/SPARK-26254?focusedCommentId=16720241&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16720241) you've mentioned `ServiceLoader` had problems with non-private to Spark API's, won't be a problem here(don't know the context)? @mridulm All in all I think it's good idea to move the custom provider load support into `HadoopDelegationTokenManager`. In order to do this [SPARK-26766](https://issues.apache.org/jira/browse/SPARK-26766) has to be resolved first(another reason why move `YarnSparkHadoopUtil.hadoopFSsToAccess`). What I not yet caught why `HadoopDelegationTokenManager` should be `@DeveloperApi`? Presume only `HadoopDelegationTokenProvider` has to be exposed, hasn't it?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
