alexarchambault edited a comment on issue #23607: [SPARK-26681][SQL] Support 
Ammonite inner-class scopes.
URL: https://github.com/apache/spark/pull/23607#issuecomment-458863676
 
 
   This was added in the context of 
[ammonite-spark](https://github.com/alexarchambault/ammonite-spark), which is a 
project of mine… There's some details about it in its 
[README](https://github.com/alexarchambault/ammonite-spark/blob/master/README.md)
 and the INTERNALS.md document in the ammonite-spark repo. Note that it works 
with Ammonite 1.6.0 as of now, not later versions. The scala jupyter kernel 
[almond](https://github.com/almond-sh/almond) relies on it for spark stuff.
   
   I guess adding a `def addOuterScopes(pf: PartialFunction[String, AnyRef]): 
Unit` (edit: made the function partial) method to add one's own outer scopes at 
once, instead of the hard-coded `AmmoniteREPLClass` of this PR, would have 
worked as well, and would have been more generic and not tied to details that 
could change in both Ammonite or ammonite-spark.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to