srowen commented on a change in pull request #23574: [SPARK-26643][SQL] Fix
incorrect analysis exception about set table properties.
URL: https://github.com/apache/spark/pull/23574#discussion_r252263813
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala
##########
@@ -129,7 +129,7 @@ private[spark] class HiveExternalCatalog(conf: SparkConf,
hadoopConf: Configurat
val invalidKeys =
table.properties.keys.filter(_.startsWith(SPARK_SQL_PREFIX))
if (invalidKeys.nonEmpty) {
throw new AnalysisException(s"Cannot persistent ${table.qualifiedName}
into hive metastore " +
- s"as table property keys may not start with '$SPARK_SQL_PREFIX': " +
+ s"as table property keys may start with '$SPARK_SQL_PREFIX': " +
Review comment:
I don't understand this change; it's checking whether table properties start
with this prefix, and it's an error if they do. The error said it's not allowed
before, but now it says it is. Isn't that reversed?
Do you mean something like, internal keys that start with this prefix are
reserved, and user-specified keys may not start with the prefix? but I think
the existing message already communicated the latter part.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
