maropu commented on a change in pull request #23259: [SPARK-26215][SQL] Define
reserved keywords based on the ANSI SQL standard
URL: https://github.com/apache/spark/pull/23259#discussion_r252270856
##########
File path:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -744,40 +750,36 @@ number
| MINUS? BIGDECIMAL_LITERAL #bigDecimalLiteral
;
+reserved
+ // A list of reserved keywords in SparkSQL. These keywords are reserved in
all the ANSI SQL standards
+ // (SQL-92, SQL-99, SQL-2003, SQL-2008, SQL-2011, and SQL-2016) and
PostgreSQL.
+ : ALL | AND | ANY | AS | AUTHORIZATION | BOTH | CASE | CAST | CHECK |
COLLATE | COLUMN | CONSTRAINT | CREATE
+ | CROSS | CURRENT_DATE | CURRENT_TIME | CURRENT_TIMESTAMP | CURRENT_USER |
DISTINCT | ELSE | END | EXCEPT
+ | FALSE | FETCH | FOR | FOREIGN | FROM | FULL | GRANT | GROUP | HAVING |
IN | INNER | INTERSECT | INTO | IS
+ | JOIN | LEADING | LEFT | NATURAL | NOT | NULL | ON | ONLY | OR | ORDER |
OUTER | OVERLAPS | PRIMARY
+ | REFERENCES | RIGHT | SELECT | SESSION_USER | SOME | TABLE | THEN | TO |
TRAILING | UNION | UNIQUE | USER
+ | USING | VARYING | WHEN | WHERE | WITH
+ ;
+
nonReserved
- : SHOW | TABLES | COLUMNS | COLUMN | PARTITIONS | FUNCTIONS | DATABASES
- | ADD
- | OVER | PARTITION | RANGE | ROWS | PRECEDING | FOLLOWING | CURRENT | ROW
| LAST | FIRST | AFTER
- | MAP | ARRAY | STRUCT
- | PIVOT | LATERAL | WINDOW | REDUCE | TRANSFORM | SERDE | SERDEPROPERTIES
| RECORDREADER
- | DELIMITED | FIELDS | TERMINATED | COLLECTION | ITEMS | KEYS | ESCAPED |
LINES | SEPARATED
- | EXTENDED | REFRESH | CLEAR | CACHE | UNCACHE | LAZY | GLOBAL | TEMPORARY
| OPTIONS
- | GROUPING | CUBE | ROLLUP
- | EXPLAIN | FORMAT | LOGICAL | FORMATTED | CODEGEN | COST
- | TABLESAMPLE | USE | TO | BUCKET | PERCENTLIT | OUT | OF
- | SET | RESET
- | VIEW | REPLACE
- | IF
- | POSITION
- | EXTRACT
- | NO | DATA
- | START | TRANSACTION | COMMIT | ROLLBACK | IGNORE
- | SORT | CLUSTER | DISTRIBUTE | UNSET | TBLPROPERTIES | SKEWED | STORED |
DIRECTORIES | LOCATION
- | EXCHANGE | ARCHIVE | UNARCHIVE | FILEFORMAT | TOUCH | COMPACT |
CONCATENATE | CHANGE
- | CASCADE | RESTRICT | BUCKETS | CLUSTERED | SORTED | PURGE | INPUTFORMAT
| OUTPUTFORMAT
- | DBPROPERTIES | DFS | TRUNCATE | COMPUTE | LIST
- | STATISTICS | ANALYZE | PARTITIONED | EXTERNAL | DEFINED | RECORDWRITER
- | REVOKE | GRANT | LOCK | UNLOCK | MSCK | REPAIR | RECOVER | EXPORT |
IMPORT | LOAD | VALUES | COMMENT | ROLE
- | ROLES | COMPACTIONS | PRINCIPALS | TRANSACTIONS | INDEX | INDEXES |
LOCKS | OPTION | LOCAL | INPATH
- | ASC | DESC | LIMIT | RENAME | SETS
- | AT | NULLS | OVERWRITE | ALL | ANY | ALTER | AS | BETWEEN | BY | CREATE
| DELETE
- | DESCRIBE | DROP | EXISTS | FALSE | FOR | GROUP | IN | INSERT | INTO | IS
|LIKE
- | NULL | ORDER | OUTER | TABLE | TRUE | WITH | RLIKE
- | AND | CASE | CAST | DISTINCT | DIV | ELSE | END | FUNCTION | INTERVAL |
MACRO | OR | STRATIFY | THEN
- | UNBOUNDED | WHEN
- | DATABASE | SELECT | FROM | WHERE | HAVING | TO | TABLE | WITH | NOT
- | DIRECTORY
- | BOTH | LEADING | TRAILING
+ : ADD | AFTER | ALL | ALTER | ANALYZE | AND | ANY | ARCHIVE | ARRAY | AS |
ASC | AT | BETWEEN | BOTH
+ | BUCKET | BUCKETS | BY | CACHE | CASCADE | CASE | CAST | CHANGE | CLEAR |
CLUSTER | CLUSTERED | CODEGEN
+ | COLLECTION | COLUMN | COLUMNS | COMMENT | COMMIT | COMPACT | COMPACTIONS
| COMPUTE | CONCATENATE | COST
+ | CREATE | CUBE | CURRENT | DATA | DATABASE | DATABASES | DBPROPERTIES |
DEFINED | DELETE | DELIMITED
+ | DESC | DESCRIBE | DFS | DIRECTORIES | DIRECTORY | DISTINCT | DISTRIBUTE
| DIV | DROP | ELSE | END
+ | ESCAPED | EXCHANGE | EXISTS | EXPLAIN | EXPORT | EXTENDED | EXTERNAL |
EXTRACT | FALSE | FIELDS
+ | FILEFORMAT | FIRST | FOLLOWING | FOR | FORMAT | FORMATTED | FROM |
FUNCTION | FUNCTIONS | GLOBAL
+ | GRANT | GROUP | GROUPING | HAVING | IF | IGNORE | IMPORT | IN | INDEX |
INDEXES | INPATH | INPUTFORMAT
+ | INSERT | INTERVAL | INTO | IS |LIKE | ITEMS | KEYS | LAST | LATERAL |
LAZY | LEADING | LIMIT | LINES
+ | LIST | LOAD | LOCAL | LOCATION | LOCK | LOCKS | LOGICAL | MACRO | MAP |
MSCK | NO | NOT | NULL | NULLS
+ | OF | OPTION | OPTIONS | OR | ORDER | OUT | OUTER | OUTPUTFORMAT | OVER |
OVERWRITE | PARTITION
+ | PARTITIONED | PARTITIONS | PERCENTLIT | PIVOT | POSITION | PRECEDING |
PRINCIPALS | PURGE | RANGE
+ | RECORDREADER | RECORDWRITER | RECOVER | REDUCE | REFRESH | RENAME |
REPAIR | REPLACE | RESET | RESTRICT
+ | REVOKE | RLIKE | ROLE | ROLES | ROLLBACK | ROLLUP | ROW | ROWS | SELECT
| SEPARATED | SERDE
+ | SERDEPROPERTIES | SET | SETS | SHOW | SKEWED | SORT | SORTED | START |
STATISTICS | STORED | STRATIFY
+ | STRUCT | TABLE | TABLES | TABLESAMPLE | TBLPROPERTIES | TEMPORARY |
TERMINATED | THEN | TO | TOUCH
+ | TRAILING | TRANSACTION | TRANSACTIONS | TRANSFORM | TRUE | TRUNCATE |
UNARCHIVE | UNBOUNDED | UNCACHE
+ | UNLOCK | UNSET | USE | VALUES | VIEW | WHEN | WHERE | WINDOW | WITH
;
Review comment:
Based on [the
suggestion](https://github.com/apache/spark/pull/23259#issuecomment-445519022),
I need more time to think more about this part; we might need three parts here,
`reserved-in-ansi`, `non-reserved-in-ansi`, and the current `nonReserved`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
