srowen commented on issue #23693: [SPARK-26768][CORE]Remove useless code in BlockManager URL: https://github.com/apache/spark/pull/23693#issuecomment-458972550 To check my understanding, the TorrentBroadcast caller won't ever operate on shuffled blocks? Maybe add an assert and comment about this to test. I think this is probably indeed old code and an optimization that only 'should work', and may not even be tested. I'm hesitant to change logic here but it does look removable. An assert and tests will help establish that.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
