pgandhi999 commented on a change in pull request #22806: [SPARK-25250][CORE] :
Late zombie task completions handled correctly even before new taskset launched
URL: https://github.com/apache/spark/pull/22806#discussion_r252353118
##########
File path:
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala
##########
@@ -160,6 +162,15 @@ class DAGSchedulerSuite extends SparkFunSuite with
LocalSparkContext with TimeLi
override def executorLost(executorId: String, reason: ExecutorLossReason):
Unit = {}
override def workerRemoved(workerId: String, host: String, message:
String): Unit = {}
override def applicationAttemptId(): Option[String] = None
+ // Since, the method completeTasks in TaskSchedulerImpl.scala marks the
partition complete
+ // for all stage attempts in the particular stage id, it does not need any
info about
+ // stageAttemptId. Hence, completed partition id's are stored only for
stage id's to mock
+ // the method implementation here.
+ override def completeTasks(partitionId: Int, stageId: Int, taskInfo:
TaskInfo): Unit = {
+ val partitionIds = completedPartitions.getOrElseUpdate(stageId, new
HashSet[Int])
+ partitionIds.add(partitionId)
+ completedPartitions(stageId) = partitionIds
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
