liancheng commented on issue #23607: [SPARK-26681][SQL] Support Ammonite inner-class scopes. URL: https://github.com/apache/spark/pull/23607#issuecomment-459048204 @rdblue My major concern about this PR is that this change doesn't have any tests (and it's pretty hard to add one). Considering that this change is coupled with Spark, Scala, and Ammonite versions, it's hard to make sure we can surface possible regressions in time whenever any of these versions get updated. I think the approach @alexarchambault brought up is better because it's REPL agnostic and it's much easier to write a test against a generic `addOuterScopes()` method.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
