srowen commented on issue #23607: [SPARK-26681][SQL] Support Ammonite inner-class scopes. URL: https://github.com/apache/spark/pull/23607#issuecomment-459064462 Sure, I mean, YARN, ORC, ganglia, tachyon in the past? etc, etc. Spark has a lot of code to support third-party things as you know. I know your point is that we don't want to add a bunch of exceptions and workarounds to complicate Spark just to accommodate every third-party library out there, and I agree. I don't think we have a formal policy. It's up to our judgment. There is no slippery-slope here. The logic here is simply that it doesn't impact Spark otherwise, and is a few lines of code, and does help a small class of Spark users. I think the judgment to merge this is fine; I was confident about it. Tests are good but how would you test it, and what would you document? We can revert or modify it if others feel strongly, but, now that you've reviewed it, what is your concern? just that it needs some docs? I'd like to get you and other committers in front of more changes for review before they're merged rather than after the fact, but, I know everyone's busy and sometimes we pay attention to these things only when they arrive downstream in an integration branch.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
