rdblue commented on issue #23607: [SPARK-26681][SQL] Support Ammonite inner-class scopes. URL: https://github.com/apache/spark/pull/23607#issuecomment-459064448 > Considering that this change is coupled with Spark, Scala, and Ammonite versions, it's hard to make sure we can surface possible regressions in time whenever any of these versions get updated. If that is true, I agree. My rationale was that Ammonite doesn't often change how it creates classes from blocks of code from the REPL. The version for the basic Scala REPL hasn't changed in 3 years. If Ammonite is similar then I think it is reasonable to go ahead with this tiny bit of code. If this does actually break after version 1.6.0, as alleged by @alexarchambault, then we should remove it. But it isn't clear what his statements meant. If bumping the version in ammonite-spark fixes the problem, then it sounds like the problem is ammonite-spark, not this patch.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
