gatorsmile commented on issue #23607: [SPARK-26681][SQL] Support Ammonite inner-class scopes. URL: https://github.com/apache/spark/pull/23607#issuecomment-459168879 In Spark SQL, we rejected all the similar PRs in the past and I do not remember we made any exception in the past. We normally suggest users to do it in their forks, instead of merging/maintaining them in the upstream. We are very conservative in the code merging, especially when we are not familiar with the changes. For example, the other contributors try it, realize that it does not work well and submit more PRs. We even do not know who can review the changes. For this specific PR, actually, @zsxwing @lihaoyi @liancheng had an internal Hackathon project for supporting Ammonite, which is much better than Scala Repl TBH. However, based on my understanding, the sizing is not small if we want to make an official support of Ammonite in Apache Spark. If we want to officially support it, we might need a SPIP with a clear design doc. So far, I think very few people can actually lead this effort to finish, review and maintain it. Thus, I do not think we should simply merge this PR and maintain it without knowing the context, the scope and the motivation. WDYT? @srowen
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
