HyukjinKwon commented on issue #23607: [SPARK-26681][SQL] Support Ammonite inner-class scopes. URL: https://github.com/apache/spark/pull/23607#issuecomment-459173950 @rdblue and @srowen, I admit I haven't taken a close look so I have no opinions about its details. Maybe I can put more inputs later after reviewing this closely. I have no issue for the fact it was merged - I feel in the same way on your point about review, Sean. We can discuss later if someone raises an issue imho. My only issue is that I think usually we take an approach for a general fix rather than for one (arguably less-known) third-party project, otherwise I have left -0 or -1 so far. How many projects do need similar changes (to see if we need a general fix) and how many users do get affected (to see if it's worth getting in alone)? Looks this point wasn't made here. Being non-invasive is good to judge when to merge a PR but we should see if that's worth as well.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
