rednaxelafx commented on a change in pull request #23701: [SPARK-26741][SQL]
Allow using aggregate expressions in ORDER BY clause
URL: https://github.com/apache/spark/pull/23701#discussion_r252506702
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -1676,6 +1676,23 @@ class Analyzer(
// just return the original plan.
case ae: AnalysisException => sort
}
+ case sort @ Sort(sortOrders, _, child)
Review comment:
I wonder if this case can be folded up into the previous case. They're not
that different, right? The previous case handles direct child being `Aggregate`
and this new case handles indirect child being `Aggregate`, but otherwise they
should do similar things.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
