lihaoyi commented on issue #23607: [SPARK-26681][SQL] Support Ammonite inner-class scopes. URL: https://github.com/apache/spark/pull/23607#issuecomment-459183667 @gatorsmile our hackathon project was mostly integration with the company-specific code. @alexarchambault is probabpy the expert on what is necessary on the OSS side of the ammonite+spark integration. I don’t mind merging this PR in principle. The maintenance overhead seems negligible, and if it helps some people start using ammonite+spark more then great. If it breaks in future versions of either then whoever cares can fix it, but having something work even without unofficial support is a good way to get people interested enough to develop official support in future. -Haoyi On Thu, 31 Jan 2019 at 9:06 AM, Hyukjin Kwon <[email protected]> wrote: > @rdblue <https://github.com/rdblue> and @srowen > <https://github.com/srowen>, I admit I haven't taken a close look so I > have no opinions about its details. Maybe I can put more inputs later after > reviewing this closely. I have no issue for the fact it was merged - I feel > in the same way on your point about review, Sean. We can discuss later if > someone raises an issue imho. > > My only issue is that I think usually we take an approach for a general > fix rather than for one (arguably less-known) third-party project, > otherwise I have left -0 or -1 so far. How many projects do need similar > changes (to see if we need a general fix) and how many users do get > affected (to see if it's worth getting in alone)? Looks this point wasn't > made here. > > Being non-invasive is good to judge when to merge a PR but we should see > if that's worth as well. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/spark/pull/23607#issuecomment-459173950>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/AA5A_OKPjipGY-ZpSr5X-HqWrx3h2t8yks5vIkF4gaJpZM4aLusA> > . >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
