gatorsmile commented on issue #23692: [SPARK-26448][SQL][followup] should not normalize grouping expressions for final aggregate URL: https://github.com/apache/spark/pull/23692#issuecomment-459248742 LGTM since the current hack will be removed soon. On Wed, Jan 30, 2019 at 11:47 PM Wenchen Fan <[email protected]> wrote: > *@cloud-fan* commented on this pull request. > ------------------------------ > > In > sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala > <https://github.com/apache/spark/pull/23692#discussion_r252562555>: > > > @@ -331,8 +332,17 @@ abstract class SparkStrategies extends QueryPlanner[SparkPlan] { > > val stateVersion = conf.getConf(SQLConf.STREAMING_AGGREGATION_STATE_FORMAT_VERSION) > > + // Ideally this should be done in `NormalizeFloatingNumbers`, but we do it here because > + // `groupingExpressions` is not extracted during logical phase. > > yea > > — > You are receiving this because you were mentioned. > > > Reply to this email directly, view it on GitHub > <https://github.com/apache/spark/pull/23692#discussion_r252562555>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/ALCApUDTB69icwWGqz6tjj3FguVL_-ATks5vIp-hgaJpZM4aZix8> > . >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
