HeartSaVioR edited a comment on issue #23634: [SPARK-26154][SS] Streaming 
left/right outer join should not return outer nulls for already matched rows
URL: https://github.com/apache/spark/pull/23634#issuecomment-459299774
 
 
   Just applied the approach 2 and removed `[WIP]`. Also added the UT which 
restore the query from previous state (2.4.0).
   
   The code may have some redundant parts: not only state format but also the 
logic have to be versioned so it's not trivial to abstract them all. I'm 
planning to reduce duplication, but I'd be really appreciated someone could 
help me to find out where and how to clean up the code, or even restructure 
packages/traits/classes.
   
   Thanks in advance for all reviewers!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to