srowen commented on a change in pull request #23700: [SPARK-25692] [CORE] Remove static initialization of worker eventLoop handling chunk fetch requests within TransportContext. This fixes ChunkFetchIntegrationSuite as well URL: https://github.com/apache/spark/pull/23700#discussion_r252670792
########## File path: common/network-common/src/main/java/org/apache/spark/network/TransportContext.java ########## @@ -88,7 +88,7 @@ // Separate thread pool for handling ChunkFetchRequest. This helps to enable throttling // max number of TransportServer worker threads that are blocked on writing response // of ChunkFetchRequest message back to the client via the underlying channel. - private static EventLoopGroup chunkFetchWorkers; + private EventLoopGroup chunkFetchWorkers; Review comment: This can be final, though will require explicitly setting it to null in the constructor if not otherwise initialized ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
