redsanket commented on a change in pull request #23700: [SPARK-25692] [CORE]
Remove static initialization of worker eventLoop handling chunk fetch requests
within TransportContext. This fixes ChunkFetchIntegrationSuite as well
URL: https://github.com/apache/spark/pull/23700#discussion_r252681770
##########
File path:
common/network-common/src/main/java/org/apache/spark/network/TransportContext.java
##########
@@ -122,16 +122,14 @@ public TransportContext(
this.closeIdleConnections = closeIdleConnections;
this.isClientOnly = isClientOnly;
- synchronized(TransportContext.class) {
- if (chunkFetchWorkers == null &&
- conf.getModuleName() != null &&
- conf.getModuleName().equalsIgnoreCase("shuffle") &&
- !isClientOnly) {
- chunkFetchWorkers = NettyUtils.createEventLoop(
- IOMode.valueOf(conf.ioMode()),
- conf.chunkFetchHandlerThreads(),
- "shuffle-chunk-fetch-handler");
- }
+ if (chunkFetchWorkers == null &&
Review comment:
yes i think this was more of a defensive check when static was around will
remove thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
