dongjoon-hyun commented on a change in pull request #23714:
[SPARK-26744][SQL]Support schema validation in FileDataSourceV2 framework
URL: https://github.com/apache/spark/pull/23714#discussion_r252783438
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/FileScan.scala
##########
@@ -18,22 +18,29 @@ package org.apache.spark.sql.execution.datasources.v2
import org.apache.hadoop.fs.Path
-import org.apache.spark.sql.SparkSession
+import org.apache.spark.sql.{AnalysisException, SparkSession}
import org.apache.spark.sql.execution.PartitionedFileUtil
import org.apache.spark.sql.execution.datasources._
import org.apache.spark.sql.sources.v2.reader.{Batch, InputPartition, Scan}
-import org.apache.spark.sql.types.StructType
+import org.apache.spark.sql.types.{DataType, StructType}
abstract class FileScan(
sparkSession: SparkSession,
- fileIndex: PartitioningAwareFileIndex) extends Scan with Batch {
+ fileIndex: PartitioningAwareFileIndex,
+ readSchema: StructType) extends Scan with Batch {
/**
* Returns whether a file with `path` could be split or not.
*/
def isSplitable(path: Path): Boolean = {
false
}
+ /**
+ * Returns whether this format supports the given [[DataType]] in write path.
+ * By default all data types are supported.
+ */
+ def supportDataType(dataType: DataType): Boolean = true
Review comment:
Hi, @gengliangwang and @cloud-fan .
In DSv2, I guess it would be more natural to have a Java interface for this
validation API. How do you think about that?
cc @rdblue since this is DSv2.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
