rdblue commented on a change in pull request #23606: [SPARK-26666][SQL] Support
DSv2 overwrite and dynamic partition overwrite.
URL: https://github.com/apache/spark/pull/23606#discussion_r252919336
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/sources/filters.scala
##########
@@ -218,3 +218,23 @@ case class StringEndsWith(attribute: String, value:
String) extends Filter {
case class StringContains(attribute: String, value: String) extends Filter {
override def references: Array[String] = Array(attribute)
}
+
+/**
+ * A filter that always evaluates to `true`.
+ */
+case class AlwaysTrue() extends Filter {
Review comment:
There's an object that extends it just below. I thought it was still a good
idea to match the pattern of the other filters and make a class as well as an
object, since this will be used by Java code. Checking `instanceof AlwaysTrue$`
leaks Scala details into Java.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
