gatorsmile commented on a change in pull request #23709:
[SPARK-26794][SQL]SparkSession enableHiveSupport does not point to hive but
in-memory while the SparkContext exists
URL: https://github.com/apache/spark/pull/23709#discussion_r252959148
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala
##########
@@ -68,13 +82,14 @@ private[sql] class SharedState(val sparkContext:
SparkContext) extends Logging {
// the value of spark.sql.warehouse.dir.
// When neither spark.sql.warehouse.dir nor hive.metastore.warehouse.dir
is set,
// we will set hive.metastore.warehouse.dir to the default value of
spark.sql.warehouse.dir.
- val sparkWarehouseDir = sparkContext.conf.get(WAREHOUSE_PATH)
+ val sparkWarehouseDir = conf.get(WAREHOUSE_PATH)
logInfo(s"Setting hive.metastore.warehouse.dir ('$hiveWarehouseDir') to
the value of " +
s"${WAREHOUSE_PATH.key} ('$sparkWarehouseDir').")
- sparkContext.hadoopConfiguration.set("hive.metastore.warehouse.dir",
sparkWarehouseDir)
+ hadoopConf.set("hive.metastore.warehouse.dir", sparkWarehouseDir)
sparkWarehouseDir
}
}
+ sparkContext.conf.set(WAREHOUSE_PATH.key, warehousePath)
logInfo(s"Warehouse path is '$warehousePath'.")
Review comment:
What is the reason we keep the line 107 `new
SQLAppStatusListener(sparkContext.conf` unchanged?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
