gaborgsomogyi commented on a change in pull request #23716: [SPARK-26734]
[STREAMING] Fix StackOverflowError with large block queue
URL: https://github.com/apache/spark/pull/23716#discussion_r253016256
##########
File path:
streaming/src/test/scala/org/apache/spark/streaming/ReceivedBlockTrackerSuite.scala
##########
@@ -96,6 +96,13 @@ class ReceivedBlockTrackerSuite
receivedBlockTracker.getUnallocatedBlocks(streamId) shouldEqual blockInfos
}
+ test("block addition, and block to batch allocation with many blocks") {
+ val receivedBlockTracker = createTracker(setCheckpointDir = true)
+ val blockInfos = generateBlockInfos(100000)
+ blockInfos.map(receivedBlockTracker.addBlock)
+ receivedBlockTracker.allocateBlocksToBatch(1)
Review comment:
I would add assertions here as well. If it's not throwing exception doesn't
mean the same blocks deserialized.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
