attilapiros commented on a change in pull request #23721:
[SPARK-26797][SQL][WIP] Start using the new logical types API of Parquet 1.11.0
instead of the deprecated one
URL: https://github.com/apache/spark/pull/23721#discussion_r253212347
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRowConverter.scala
##########
@@ -301,7 +316,8 @@ private[parquet] class ParquetRowConverter(
// A repeated field that is neither contained by a `LIST`- or
`MAP`-annotated group nor
// annotated by `LIST` or `MAP` should be interpreted as a required list
of required
// elements where the element type is the type of the field.
- case t: ArrayType if parquetType.getOriginalType != LIST =>
+ case t: ArrayType
+ if
!parquetType.getLogicalTypeAnnotation.isInstanceOf[ListLogicalTypeAnnotation] =>
Review comment:
Nit: the two ifs indented in the same level looks suspicious. I suggest to
keep the if at the line of case and indent the condition with 4 spaces.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
