srowen commented on a change in pull request #23716: [SPARK-26734] [STREAMING]
Fix StackOverflowError with large block queue
URL: https://github.com/apache/spark/pull/23716#discussion_r253231539
##########
File path:
streaming/src/main/scala/org/apache/spark/streaming/scheduler/ReceivedBlockTracker.scala
##########
@@ -112,7 +112,7 @@ private[streaming] class ReceivedBlockTracker(
def allocateBlocksToBatch(batchTime: Time): Unit = synchronized {
if (lastAllocatedBatchTime == null || batchTime > lastAllocatedBatchTime) {
val streamIdToBlocks = streamIds.map { streamId =>
- (streamId, getReceivedBlockQueue(streamId).clone())
+ (streamId, getReceivedBlockQueue(streamId).clone().dequeueAll(x =>
true))
Review comment:
Yes I think that's the point here indeed, but a Queue apparently has a
linked-list-like representation. ArrayBuffer won't. Are you saying that's the
right change or no? my point was we're not actually guaranteed what dequeueAll
returns.
A comment would be good, sure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
