mgaido91 commented on issue #23725: [SPARK-26814][SQL] Avoid unnecessary block concatenation while empty block exists URL: https://github.com/apache/spark/pull/23725#issuecomment-459947763 there was an argument against this approach, which is actually adopted only in few places of the codebase. I don't think this change is worth, we should rather go ahead with the IR representation which I saw got a bit stuck lately. Once that will be ready, this whole methods are useless. Actually, if we agree to abandon the adoption of this, we could revert and remove it.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
