viirya commented on a change in pull request #23728: [SPARK-26818][ML] Make
MLEvents JSON ser/de safe
URL: https://github.com/apache/spark/pull/23728#discussion_r253295539
##########
File path: mllib/src/main/scala/org/apache/spark/ml/events.scala
##########
@@ -91,46 +124,58 @@ private[ml] trait MLEvents extends Logging {
def withFitEvent[M <: Model[M]](
estimator: Estimator[M], dataset: Dataset[_])(func: => M): M = {
- val startEvent = FitStart(estimator, dataset)
+ val startEvent = FitStart[M]()
+ startEvent.estimator = estimator
+ startEvent.dataset = dataset
logEvent(startEvent)
listenerBus.post(startEvent)
val model: M = func
- val endEvent = FitEnd(estimator, model)
+ val endEvent = FitEnd[M]()
+ endEvent.estimator = estimator
+ endEvent.model = model
logEvent(endEvent)
listenerBus.post(endEvent)
model
}
def withTransformEvent(
transformer: Transformer, input: Dataset[_])(func: => DataFrame):
DataFrame = {
- val startEvent = TransformStart(transformer, input)
+ val startEvent = TransformStart()
+ startEvent.transformer = transformer
+ startEvent.input = input
logEvent(startEvent)
listenerBus.post(startEvent)
val output: DataFrame = func
- val endEvent = TransformEnd(transformer, output)
+ val endEvent = TransformEnd()
+ endEvent.transformer = transformer
+ endEvent.output = output
logEvent(endEvent)
listenerBus.post(endEvent)
output
}
def withLoadInstanceEvent[T](reader: MLReader[T], path: String)(func: => T):
T = {
- val startEvent = LoadInstanceStart(reader, path)
+ val startEvent = LoadInstanceStart[T](path)
+ startEvent.reader = reader
logEvent(startEvent)
listenerBus.post(startEvent)
val instance: T = func
- val endEvent = LoadInstanceEnd(reader, instance)
+ val endEvent = LoadInstanceEnd[T]()
+ endEvent.reader = reader
+ endEvent.instance = instance
logEvent(endEvent)
listenerBus.post(endEvent)
instance
}
def withSaveInstanceEvent(writer: MLWriter, path: String)(func: => Unit):
Unit = {
- listenerBus.post(SaveInstanceEnd(writer, path))
Review comment:
This was wrongly committed previously?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
