vanzin commented on a change in pull request #23688: [SPARK-25035][Core]
Avoiding memory mapping at disk-stored blocks replication
URL: https://github.com/apache/spark/pull/23688#discussion_r253696098
##########
File path: core/src/main/scala/org/apache/spark/storage/DiskStore.scala
##########
@@ -126,6 +127,12 @@ private[spark] class DiskStore(
}
}
+ def moveFileToBlock(sourceFile: File, blockSize: Long, targetBlockId:
BlockId): Unit = {
+ blockSizes.put(targetBlockId, blockSize)
Review comment:
I assume that the temp block size is not in `blockSizes`?
`TempFileBasedBlockStoreUpdater.toBlockData` calls a `DiskStore` API with a
temp block id, so I was wondering if all the temp block metadata is tracked by
this class, or just its location.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
