maropu commented on a change in pull request #23731: [SPARK-26572][SQL] fix
aggregate codegen result evaluation
URL: https://github.com/apache/spark/pull/23731#discussion_r253712454
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
##########
@@ -466,10 +466,12 @@ case class HashAggregateExec(
val resultVars = bindReferences[Expression](
resultExpressions,
inputAttrs).map(_.genCode(ctx))
+ val evaluateResultVars = evaluateVariables(resultVars)
s"""
$evaluateKeyVars
$evaluateBufferVars
$evaluateAggResults
+ $evaluateResultVars
Review comment:
If so, could you please add test cases to cover all the code paths you added
in this pr.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
