skonto commented on a change in pull request #23599: [SPARK-24793][K8s] Enhance
spark-submit for app management
URL: https://github.com/apache/spark/pull/23599#discussion_r253824826
##########
File path: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala
##########
@@ -95,20 +95,66 @@ private[spark] class SparkSubmit extends Logging {
}
/**
- * Kill an existing submission using the REST protocol. Standalone and Mesos
cluster mode only.
+ * Kill an existing submission.
+ * Standalone, Kubernetes and Mesos cluster mode only.
*/
private def kill(args: SparkSubmitArguments): Unit = {
- new RestSubmissionClient(args.master)
- .killSubmission(args.submissionToKill)
+ if (args.master.startsWith("k8s://")) {
+ try {
+ val ops =
Utils.classForName("org.apache.spark.deploy.k8s.submit.K8sSubmitOps$")
Review comment:
Ok for this PR makes 100% sense, for the deps stuff it can be kept as is
since it is k8s specific and I need to parse some maven coordinates and skip
others to make things work.
Yes I dont need to make an abstraction for everything. I will fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
