squito commented on a change in pull request #23688: [SPARK-25035][Core]
Avoiding memory mapping at disk-stored blocks replication
URL: https://github.com/apache/spark/pull/23688#discussion_r254081261
##########
File path: core/src/main/scala/org/apache/spark/storage/DiskStore.scala
##########
@@ -126,6 +127,12 @@ private[spark] class DiskStore(
}
}
+ def moveFileToBlock(sourceFile: File, blockSize: Long, targetBlockId:
BlockId): Unit = {
+ blockSizes.put(targetBlockId, blockSize)
Review comment:
add a comment here that `blockSize` that if encryption is configured, the
file is assumed to already be encrypted, and that blockSize should be the
decrypted size.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
