soxofaan commented on a change in pull request #23736: bin/pyspark: eliminate
use of hardcoded 'python' command and fix IPython version check
URL: https://github.com/apache/spark/pull/23736#discussion_r254187221
##########
File path: bin/pyspark
##########
@@ -42,11 +42,10 @@ if [[ -z "$PYSPARK_DRIVER_PYTHON" ]]; then
PYSPARK_DRIVER_PYTHON="${PYSPARK_PYTHON:-"python"}"
fi
-WORKS_WITH_IPYTHON=$(python -c 'import sys; print(sys.version_info >= (2, 7,
0))')
-
# Determine the Python executable to use for the executors:
if [[ -z "$PYSPARK_PYTHON" ]]; then
- if [[ $PYSPARK_DRIVER_PYTHON == *ipython* && ! $WORKS_WITH_IPYTHON ]]; then
+ WORKS_WITH_IPYTHON=$($PYSPARK_DRIVER_PYTHON -c 'import sys;
print(sys.version_info >= (2, 7, 0))')
Review comment:
I found this part indeed very confusing.
I'll change it back to `WORKS_WITH_IPYTHON=$(python -c 'import sys;
print(sys.version_info >= (2, 7, 0))')`
It's already an improvement that this part is inside `if [[ -z
"$PYSPARK_PYTHON" ]];`
But indeed, if spark already requires at least py2.7, all this version
checking could be reconsidered in the first place
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
